Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(campaign): remove AuctionsOfCampaign #892

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Jul 12, 2022

Remove AuctionsOfCampaign query as we now have events for campaign auctions creation and UI will be built on top of this functionality

@lumtis lumtis linked an issue Jul 12, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #892 (e332bd8) into develop (16209ef) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #892      +/-   ##
===========================================
+ Coverage    10.39%   10.43%   +0.03%     
===========================================
  Files          332      330       -2     
  Lines        77301    76837     -464     
===========================================
- Hits          8039     8016      -23     
+ Misses       69072    68632     -440     
+ Partials       190      189       -1     
Impacted Files Coverage Δ
x/campaign/types/query.pb.go 0.65% <ø> (+<0.01%) ⬆️
x/campaign/types/query.pb.gw.go 0.00% <ø> (ø)
x/campaign/simulation/store.go 84.45% <0.00%> (+1.35%) ⬆️

@lumtis lumtis merged commit 01cb342 into develop Jul 13, 2022
@lumtis lumtis deleted the refactor/remove-campaign-auctions branch July 13, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AuctionsOfCampaign query once no longer necessary
1 participant