Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add config_26661.yml to serve chain without port collisions #900

Merged
merged 8 commits into from
Jul 20, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Jul 20, 2022

Add config_26661.yml that allows to serve spn locally but with different port exposure, mort importantly rpc on 26661.

This allows to run ignite network commands locally while serving the testnet as well

ignite n chain publish https://github.com/tendermint/spn --spn-node-address http://0.0.0.0:26661/ --spn-faucet-address http://0.0.0.0:4502/ --chain-id spn-1

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #900 (fcdb8fd) into develop (4b28ffb) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head fcdb8fd differs from pull request most recent head 557cd0d. Consider uploading reports for the commit 557cd0d to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #900   +/-   ##
========================================
  Coverage    10.42%   10.43%           
========================================
  Files          330      330           
  Lines        76837    76837           
========================================
+ Hits          8011     8016    +5     
+ Misses       68635    68632    -3     
+ Partials       191      189    -2     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 84.45% <0.00%> (+3.37%) ⬆️

config_26661.yml Outdated Show resolved Hide resolved
@aljo242
Copy link
Contributor

aljo242 commented Jul 20, 2022

I think the name of this file is unclear. The name should more closely reflect the purpose of the file.

Co-authored-by: Alex Johnson <alex.johnson@tendermint.com>
@lumtis
Copy link
Contributor Author

lumtis commented Jul 20, 2022

I think the name of this file is unclear. The name should more closely reflect the purpose of the file.

Maybe just config_2.yml then since the reason for this file is specified in it?

@lumtis lumtis requested a review from aljo242 July 20, 2022 14:11
aljo242
aljo242 previously approved these changes Jul 20, 2022
@lumtis lumtis merged commit fac5ad9 into develop Jul 20, 2022
@lumtis lumtis deleted the chore/config2 branch July 20, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants