Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move x/mint and x/claim #942

Merged
merged 7 commits into from
Aug 31, 2022
Merged

refactor: move x/mint and x/claim #942

merged 7 commits into from
Aug 31, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Aug 30, 2022

Closes #933

Additionally replaces the usage of spnerrors with the errors package found in ignite/modules

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #942 (ce7f44e) into develop (a74f061) will increase coverage by 0.14%.
The diff coverage is 26.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #942      +/-   ##
===========================================
+ Coverage    10.60%   10.75%   +0.14%     
===========================================
  Files          328      280      -48     
  Lines        75537    66957    -8580     
===========================================
- Hits          8009     7198     -811     
+ Misses       67339    59596    -7743     
+ Partials       189      163      -26     
Impacted Files Coverage Δ
x/campaign/keeper/msg_create_campaign.go 86.95% <0.00%> (ø)
x/campaign/keeper/msg_initialize_mainnet.go 94.23% <0.00%> (ø)
x/campaign/keeper/msg_mint_vouchers.go 69.38% <0.00%> (ø)
x/campaign/keeper/msg_unredeem_vouchers.go 63.15% <0.00%> (ø)
x/campaign/keeper/msg_update_total_supply.go 91.66% <0.00%> (ø)
x/launch/keeper/msg_create_chain.go 91.66% <0.00%> (ø)
x/launch/keeper/msg_revert_launch.go 92.68% <0.00%> (ø)
x/participation/keeper/msg_withdraw_allocations.go 83.78% <0.00%> (ø)
x/profile/keeper/msg_disable_coordinator.go 67.74% <0.00%> (ø)
x/profile/keeper/msg_update_coordinator_address.go 75.60% <0.00%> (ø)
... and 10 more

lumtis
lumtis previously approved these changes Aug 31, 2022
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@lumtis lumtis merged commit ae4ee27 into develop Aug 31, 2022
@lumtis lumtis deleted the refactor/move-mint-claim branch August 31, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing mint and claim modules
2 participants