Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(launch): merge request related messages into MsgSendRequest #947

Merged
merged 13 commits into from
Sep 7, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Sep 6, 2022

All requests merged into a single MsgSendRequest message
Same functionality, 3700 lines removed

To test: use the spnd CLI, interface remains the same

@lumtis lumtis self-assigned this Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #947 (a9203b2) into develop (c65411c) will decrease coverage by 0.07%.
The diff coverage is 58.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #947      +/-   ##
===========================================
- Coverage    10.75%   10.67%   -0.08%     
===========================================
  Files          280      272       -8     
  Lines        67161    64942    -2219     
===========================================
- Hits          7220     6931     -289     
+ Misses       59780    57849    -1931     
- Partials       161      162       +1     
Impacted Files Coverage Δ
x/launch/simulation/simulation.go 0.00% <0.00%> (ø)
x/launch/types/tx.pb.go 0.53% <ø> (+0.04%) ⬆️
x/launch/types/msg_send_request.go 30.76% <30.76%> (ø)
x/launch/keeper/msg_send_request.go 100.00% <100.00%> (ø)
x/launch/keeper/request.go 100.00% <100.00%> (ø)
x/launch/types/request_content.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 82.43% <0.00%> (-2.03%) ⬇️

@lumtis lumtis marked this pull request as ready for review September 6, 2022 15:37
Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing !!

@aljo242 aljo242 merged commit aab4d3d into develop Sep 7, 2022
@aljo242 aljo242 deleted the refactor/merge-request-messages branch September 7, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplifying launch module by merging all request related message to MsgSendRequest
2 participants