Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace unix time stamps #948

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 8, 2022

Closes #913

The only remaining time that is not time.Time or time.Duration is in proto/types/ibc.proto, where a timestamp is saved as a string. I wasn't sure what we wanted to do with this one.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #948 (a5ccf87) into develop (aab4d3d) will decrease coverage by 0.00%.
The diff coverage is 6.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #948      +/-   ##
===========================================
- Coverage    10.66%   10.66%   -0.01%     
===========================================
  Files          272      272              
  Lines        64942    64990      +48     
===========================================
  Hits          6929     6929              
- Misses       57850    57898      +48     
  Partials       163      163              
Impacted Files Coverage Δ
x/campaign/types/vesting.pb.go 2.37% <0.00%> (-0.08%) ⬇️
x/launch/types/events.pb.go 0.49% <0.00%> (-0.01%) ⬇️
x/launch/types/vesting_account.pb.go 1.80% <0.00%> (-0.05%) ⬇️
x/campaign/types/share_vesting_options.go 100.00% <100.00%> (ø)
x/launch/keeper/msg_trigger_launch.go 100.00% <100.00%> (ø)
x/launch/keeper/request.go 100.00% <100.00%> (ø)
x/launch/types/vesting_options.go 93.75% <100.00%> (ø)

@lumtis
Copy link
Contributor

lumtis commented Sep 11, 2022

The only remaining time that is not time.Time or time.Duration is in proto/types/ibc.proto, where a timestamp is saved as a string. I wasn't sure what we wanted to do with this one.

We can actually let the string

The reason is we want the ConsensusState type to be directly the unmarshaled version of the consensus state file dumped by the ibc CLI query

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit a66e29d into develop Sep 11, 2022
@lumtis lumtis deleted the refactor/replace-unix-time branch September 11, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Unix timestamps with Duration or Time
2 participants