-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: genesis names #952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #952 +/- ##
========================================
Coverage 10.66% 10.67%
========================================
Files 272 272
Lines 65062 65062
========================================
+ Hits 6941 6944 +3
+ Misses 57956 57954 -2
+ Partials 165 164 -1
|
lumtis
reviewed
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great initiative👍
Some are incorrect I think
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
lumtis
reviewed
Sep 15, 2022
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
lumtis
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic renaming of repeated genesis fields where logical. Starport by default scaffolds things with a "-List" suffix which is annoying sometimes. This is just a stylistic choice though. No important.