Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: genesis names #952

Merged
merged 16 commits into from
Sep 20, 2022
Merged

refactor: genesis names #952

merged 16 commits into from
Sep 20, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 13, 2022

Basic renaming of repeated genesis fields where logical. Starport by default scaffolds things with a "-List" suffix which is annoying sometimes. This is just a stylistic choice though. No important.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #952 (c3d4486) into develop (e13ea45) will increase coverage by 0.00%.
The diff coverage is 31.22%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #952   +/-   ##
========================================
  Coverage    10.66%   10.67%           
========================================
  Files          272      272           
  Lines        65062    65062           
========================================
+ Hits          6941     6944    +3     
+ Misses       57956    57954    -2     
+ Partials       165      164    -1     
Impacted Files Coverage Δ
pkg/types/monitoring.pb.go 0.79% <ø> (ø)
x/campaign/types/events.pb.go 0.55% <ø> (ø)
x/campaign/types/genesis.pb.go 1.58% <0.00%> (ø)
x/campaign/types/mainnet_account.pb.go 0.75% <ø> (ø)
x/campaign/types/params.pb.go 0.88% <ø> (ø)
x/campaign/types/query.pb.go 0.66% <ø> (ø)
x/campaign/types/query.pb.gw.go 0.00% <ø> (ø)
x/campaign/types/vesting.pb.go 2.37% <ø> (ø)
x/launch/simulation/simulation.go 0.00% <0.00%> (ø)
x/launch/types/chain.pb.go 1.51% <ø> (ø)
... and 39 more

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative👍

Some are incorrect I think

proto/profile/genesis.proto Outdated Show resolved Hide resolved
proto/profile/genesis.proto Outdated Show resolved Hide resolved
proto/monitoringc/genesis.proto Outdated Show resolved Hide resolved
Alex Johnson and others added 6 commits September 14, 2022 15:00
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
proto/monitoringc/genesis.proto Outdated Show resolved Hide resolved
proto/monitoringc/genesis.proto Outdated Show resolved Hide resolved
Alex Johnson and others added 4 commits September 19, 2022 08:54
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
@lumtis lumtis merged commit b3f1d20 into develop Sep 20, 2022
@lumtis lumtis deleted the refactor/genesis-name branch September 20, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants