-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launch
): change param request
#957
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #957 +/- ##
===========================================
- Coverage 10.66% 10.55% -0.11%
===========================================
Files 272 275 +3
Lines 65229 66486 +1257
===========================================
+ Hits 6954 7017 +63
- Misses 58112 59300 +1188
- Partials 163 169 +6
|
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add logic in genesis.go
for genesis export and import with ParamChange objects in the genesis state.
The easiest way to represent the genesis state would be to add LaunchID
in ParamChange
so information of type index is self-contained
message ParamChange {
string module = 1;
string param = 2;
bytes value = 3;
}
and adding in (m RequestContent) Validate(launchID uint64)
verification of the launchID same as for GenesisAccount
request
Unit tests failing due to codecov upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a query to list all param changes from a LaunchID
I think only the list query is sufficient, show query would not be necessary
Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Closes #930
@lubtd let me know what you think !