Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): remove pointer for InitialGenesis in MsgCreateChain #960

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Sep 21, 2022

I realize adapting the CLI to the recent update, it is better to not use a pointer for InitialGenesis

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #960 (c872067) into develop (142531a) will increase coverage by 0.00%.
The diff coverage is 14.28%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #960   +/-   ##
========================================
  Coverage    10.65%   10.65%           
========================================
  Files          272      272           
  Lines        65235    65229    -6     
========================================
+ Hits          6949     6952    +3     
+ Misses       58121    58113    -8     
+ Partials       165      164    -1     
Impacted Files Coverage Δ
x/launch/types/chain.pb.go 1.37% <ø> (ø)
x/launch/types/msg_create_chain.go 72.09% <ø> (ø)
x/launch/types/tx.pb.go 0.54% <0.00%> (+<0.01%) ⬆️
x/campaign/keeper/msg_initialize_mainnet.go 94.54% <100.00%> (ø)
x/launch/keeper/chain.go 97.36% <100.00%> (ø)
x/campaign/simulation/store.go 83.10% <0.00%> (+2.02%) ⬆️

@aljo242 aljo242 merged commit 8bafad8 into develop Sep 21, 2022
@aljo242 aljo242 deleted the fix/config-genesis-pointer branch September 21, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants