Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: validator and coordinator guides for ignite #962

Merged
merged 5 commits into from
Sep 23, 2022
Merged

docs: validator and coordinator guides for ignite #962

merged 5 commits into from
Sep 23, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 23, 2022

  • Should we use the term spn in the docs?

@codecov
Copy link

codecov bot commented Sep 23, 2022 •
edited
Loading

Codecov Report

Merging #962 (a513be6) into develop (5086ccb) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #962   +/-   ##
========================================
  Coverage    10.55%   10.55%           
========================================
  Files          275      275           
  Lines        66486    66486           
========================================
+ Hits          7016     7017    +1     
+ Misses       59301    59300    -1     
  Partials       169      169
Impacted Files Coverage Δ
x/campaign/simulation/store.go 83.10% <0.00%> (+0.67%) ⬆️

lumtis
lumtis reviewed Sep 23, 2022
View reviewed changes
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the term spn in the docs?

This is fine

I would suggest to add a link in the readme of the repo directing in this doc for Launching Chains usage

docs/ignite_cli/validator.md Outdated Show resolved Hide resolved
docs/ignite_cli/coordinator.md Outdated Show resolved Hide resolved
docs/ignite_cli/validator.md Outdated Show resolved Hide resolved
@aljo242 aljo242 requested a review from lumtis September 23, 2022 16:21
@aljo242 aljo242 merged commit dcf3214 into develop Sep 23, 2022
@aljo242 aljo242 deleted the docs/val-coord-guides branch September 23, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@giunatale giunatale Awaiting requested review from giunatale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljo242 @lumtis