Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(participation): normalize tests #970

Merged
merged 8 commits into from
Oct 3, 2022
Merged

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 30, 2022

Closes #849

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
However, seems an error occur in /home/runner/work/spn/spn/x/participation/simulation/store_test.go:5

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #970 (ce0eee5) into develop (3c10506) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #970   +/-   ##
========================================
  Coverage    10.54%   10.55%           
========================================
  Files          275      275           
  Lines        66486    66486           
========================================
+ Hits          7011     7016    +5     
+ Misses       59304    59301    -3     
+ Partials       171      169    -2     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 84.45% <0.00%> (+3.37%) ⬆️

@lumtis lumtis merged commit 4290d15 into develop Oct 3, 2022
@lumtis lumtis deleted the test/normalize-participation branch October 3, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize test cases for participation module
2 participants