Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): allow underscore for param name in ParamChange request #995

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Nov 25, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #995 (27a54c4) into main (a217c11) will decrease coverage by 0.66%.
The diff coverage is 15.38%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   11.21%   10.55%   -0.67%     
==========================================
  Files         278      275       -3     
  Lines       60771    66482    +5711     
==========================================
+ Hits         6818     7016     +198     
- Misses      53765    59297    +5532     
+ Partials      188      169      -19     
Impacted Files Coverage Δ
pkg/types/monitoring.pb.go 0.79% <ø> (ø)
pkg/types/validator_set.go 92.30% <ø> (ø)
pkg/types/ibc.pb.go 0.69% <4.34%> (ø)
pkg/types/consensus_state.go 100.00% <100.00%> (ø)
pkg/types/signature_counts.go 100.00% <100.00%> (ø)
...articipation/client/cli/query_total_allocations.go 0.00% <0.00%> (-88.47%) ⬇️
...cipation/client/cli/query_available_allocations.go 0.00% <0.00%> (-88.47%) ⬇️
x/campaign/client/cli/query_mainnet_account.go 40.16% <0.00%> (-40.17%) ⬇️
x/launch/types/request_content.go 91.66% <0.00%> (-8.34%) ⬇️
x/launch/simulation/store.go 58.46% <0.00%> (-7.09%) ⬇️
... and 162 more

@lumtis lumtis marked this pull request as ready for review November 25, 2022 17:21
@lumtis lumtis merged commit 052fbf5 into main Nov 25, 2022
@lumtis lumtis deleted the fix/allow-param-underscore branch November 25, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant