rpc: clean up unused non-default websocket options #7713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2022 11:05
These are only ever used with the defaults, except in our own tests. A search of cs.github.com shows no other callers. The use in the test was solely to bug out the go-metrics package so its goroutines don't trigger the leak checker. Use the package's own flag for that purpose instead. Note that calling "Stop" on the metric helps, but is not sufficient -- the Stop does not wait for its goroutine to exit.
These options are only ever used with defaults, except in tests. A search of cs.github.com reveals no other use.
creachadair
requested review from
cmwaters,
ebuchman,
tychoish and
williambanfield
as code owners
tychoish
approved these changes
Jan 27, 2022
added 2 commits
January 27, 2022 11:31
tychoish
pushed a commit
to tychoish/tendermint
that referenced
this pull request
Jan 28, 2022
…#7713) These are only ever used with the defaults, except in our own tests. A search of cs.github.com shows no other callers. The use in the test was solely to bug out the go-metrics package so its goroutines don't trigger the leak checker. Use the package's own flag for that purpose instead. Note that calling "Stop" on the metric helps, but is not sufficient -- the Stop does not wait for its goroutine to exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexport and/or remove the WSOptions types, which were never used with non-default values except in our own tests. Fix up the tests to not require the options.
Searches of cs.github.com reveal no non-default use.