Old PrepareProposal and vote extension integration on feature/abci++ppp #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PrepareProposal-VoteExtension integration (#6915) * make proto-gen * Fix protobuf crash in e2e nightly tests * Update types/vote.go Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Addressed @creachadair's comments Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
sergio-mena
requested review from
ebuchman,
cmwaters,
tychoish,
williambanfield and
creachadair
as code owners
cmwaters
approved these changes
Jul 28, 2022
Comment on lines
+135
to
+136
| // votes includes all votes from the previous block. This contains vote extension data that can be used in proposal | ||
| // preparation. The votes here will then form the last commit that gets sent in the proposed block. |
There was a problem hiding this comment.
I'm not sure if it needs to be done in this PR but this comment shouldn't mention vote extensions
There was a problem hiding this comment.
Yes, this is dealt with in the upcoming PR with the backport of #8094
3 tasks
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
…pp (#9117) * abci: PrepareProposal-VoteExtension integration [2nd try] (#7821) * PrepareProposal-VoteExtension integration (#6915) * make proto-gen * Fix protobuf crash in e2e nightly tests * Update types/vote.go Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Addressed @creachadair's comments Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Proto changes * make proto-gen * Fixed UTs * bump * lint * lint2 * lint3 * lint4 * lint5 * lint6 * no_lint Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the integration between
RequestPrepareProposaland vote extensions. We have brought it to branchfeature/abci++pppfor two reasons:PrepareProposalrelated changes depend on itPrepareProposal/ProcessProposalare released they will have their final form, with vote extensions reserved for future use (in the way the IETF does with evolving protocols and packet formats).Closes #9108