-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Range to NewIterator #134
Conversation
Can you fix the lint/golangci config? |
Could you make this PR against master, this error won't arise there, after that it can be back ported? |
wow, what a great find! |
Can you add an entry for this in |
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 69.47% 68.78% -0.70%
==========================================
Files 27 27
Lines 1448 1448
==========================================
- Hits 1006 996 -10
- Misses 370 377 +7
- Partials 72 75 +3
|
It's okay? |
Thanks! I'll run some tests with IAVL, Tendermint and the SDK using this change, and if it looks good I'll backport to 0.5.x and cut new releases - won't be able to do this until tomorrow though, since I need to finish up some other work tonight. |
Thank you, I was happy to contribute to the common cause! |
…endermint#134) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.7.1 to 4.0.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3.7.1...v4.0.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I see a slowdown when using iterations in the cosmos/iavl#324 (comment) library in the case where the given key cannot be found. I guess this is because the
newGoLevelDBIterator
function usesSeek()
, which has to go through the whole tree to make sure the key is missing.