This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Initial YubiHSM2 support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
yubihsm
branch
2 times, most recently
from
ac45d24
to
97ce715
Compare
tony-iqlusion
commented
Sep 21, 2018
| YubihsmCommand::Detect(detect) => detect.call(), | ||
| YubihsmCommand::Help(help) => help.call(), | ||
| YubihsmCommand::Keygen(keygen) => keygen.call(), | ||
| YubihsmCommand::Keys(keys) => keys.call(), |
There was a problem hiding this comment.
I should probably make this work as close to how gaiacli keys works today, and have yubihsm keys new in lieu of yubihsm keygen. How about:
yubihsm keysoryubihsm keys list: lists keysyubihsm keys generate: generates a new keyyubihsm keys delete: delete an existing keyyubihsm keys show: show detailed information about a keyyubihsm keys export: export a key under keywrapyubihsm keys import: import a key under keywrap
tarcieri
force-pushed
the
yubihsm
branch
3 times, most recently
from
316ad04
to
96b9633
Compare
Adds a `yubihsm` cargo feature with support for generating signatures using Ed25519 keys stored in YubiHSM2 devices (accessed via USB). Also adds a set of `yubihsm` subcommands: - `detect`: print a list of detected YubiHSM2 devices and their serials - `keys generate`: generate an Ed25519 key within the YubiHSM2 - `keys list`: list the keys within the YubiHSM2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
yubihsmcargo feature with support for generating signatures using Ed25519 keys stored in YubiHSM2 devices (accessed via USB).Also adds a set of
yubihsmsubcommands:detect: print a list of detected YubiHSM2 devices and their serialskeys generate: generate an Ed25519 key within the YubiHSM2keys list: list the keys within the YubiHSM2