Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support binary copy in python SDK. #419

Merged
merged 12 commits into from
Mar 20, 2024
Merged

feat: Support binary copy in python SDK. #419

merged 12 commits into from
Mar 20, 2024

Conversation

my-vegetable-has-exploded
Copy link
Contributor

close #354

@my-vegetable-has-exploded
add testcpy.
71f4c41 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
add copy by blocks
033af61 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
add perf tests.
da71827 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
move to module.
d77d23a 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
Copy link
Contributor Author

The python tests works well on my machine, but falls in ci. I don't figure out the reason.
图片
And for sparse vector, I think we need a type to descript it. Sparse vector's dimension is not the same with length, so we can't get it from ndarray.type and the adapter need to a type to register.
图片

@my-vegetable-has-exploded
add sparse vector.
8c34d2e 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
add tests & comments.
617c83f 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
fix typos.
f08f9b4 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@my-vegetable-has-exploded
Copy link
Contributor Author

It seems that our workflow use v0.2.1 not nightly image. I think ci will be happy after using nightly.

@my-vegetable-has-exploded my-vegetable-has-exploded marked this pull request as ready for review March 14, 2024 15:03
@my-vegetable-has-exploded
chores: use nightly in workflow.
b0ef6b0 
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@VoVAllen VoVAllen added this pull request to the merge queue Mar 20, 2024
Merged via the queue into tensorchord:main with commit 4b1147f Mar 20, 2024
16 checks passed
@my-vegetable-has-exploded
Copy link
Contributor Author

Thanks!

@VoVAllen
Copy link
Member

@all-contributors please add @my-vegetable-has-exploded for code contributions

@allcontributors allcontributors bot mentioned this pull request Mar 20, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@VoVAllen

I've put up a pull request to add @my-vegetable-has-exploded! 🎉

@my-vegetable-has-exploded my-vegetable-has-exploded deleted the binary-copy branch April 20, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Support binary representation in python SDK
2 participants
@my-vegetable-has-exploded @VoVAllen