Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a set of incorrect behaviors #430

Merged
merged 6 commits into from
Mar 17, 2024
Merged

fix: a set of incorrect behaviors #430

merged 6 commits into from
Mar 17, 2024

Conversation

usamoi
Copy link
Collaborator

@usamoi usamoi commented Mar 17, 2024

  • set amoptionalkey to false: it forbids PostgreSQL to generate a plan to perform a vector index scan without keys or orderByKeys; it does not lead to problems now because we set cost of such a path to an extremely large value.
  • set returned value of aminsert to false: it's not significant but we'd better return false
  • forbid scanning with a non-MVCC-compliant snapshot: if we get some physical pointers from service and they are just deleted both in a heap table and service, attemptions to get tuples by these physical pointers will fail; if some rows with these physical pointers are inserted, it even produces incorrect results. To solve it, we temporarily forbid scanning with a non-MVCC-compliant snapshot.
  • pg_vector_index_stat: we forgot to pass index oid after feat: synchronous remote index dropping #414 is implemented
  • printing info instead of throwing errors in amvalidate: it's recommended behavior in PostgreSQL document.

Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi usamoi added this pull request to the merge queue Mar 17, 2024
Merged via the queue into tensorchord:main with commit 59afde9 Mar 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant