Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix openai option gucs setting. #469

Merged

Conversation

my-vegetable-has-exploded
Copy link
Contributor

@my-vegetable-has-exploded my-vegetable-has-exploded commented Apr 19, 2024

I think those code don't matchs.

let base_url = guc_string_parse(&OPENAI_BASE_URL, "vectors.openai_base");

and

    GucRegistry::define_string_guc(
        "vectors.openai_base_url",
        "The base url of OpenAI or compatible server.",
        "",
        &OPENAI_BASE_URL,
        GucContext::Userset,
        GucFlags::default(),
    );

Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
@cutecutecat
Copy link
Member

Thanks for your fix. It's my fault without carefully check.

@cutecutecat cutecutecat added this pull request to the merge queue Apr 20, 2024
Merged via the queue into tensorchord:main with commit eaa3093 Apr 20, 2024
13 checks passed
@my-vegetable-has-exploded my-vegetable-has-exploded deleted the fix/openai-gucs branch April 20, 2024 05:49
JinweiOS pushed a commit to JinweiOS/pgvecto.rs that referenced this pull request May 21, 2024
Signed-off-by: my-vegetable-has-exploded <wy1109468038@gmail.com>
Signed-off-by: jinweios <jinwei.peng@beingthink.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants