Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colab Notebook for Normalizations #144

Merged
merged 20 commits into from
Jul 2, 2019

Conversation

Smokrow
Copy link
Contributor

@Smokrow Smokrow commented Apr 6, 2019

First draft of a Colab Notebook for Normalization layers.

I tried to formulate the description very basic and non technical for non ML experts while also including some more advanced topics like initialisers for example.

I will probably add a Recurrent example for one of the layers (Maybe layer normalization) as well.

@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/addons/pull/144

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@armando-fandango
Copy link
Contributor

Thanks @Smokrow Looks great. @seanpmorgan @facaiy should the ipynb files be in examples folder ? Because /docs folder would be overwritten everytime we run API docs generator.

@Smokrow
Copy link
Contributor Author

Smokrow commented Apr 6, 2019

Good point. I will move it

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Smokrow this looks great and thanks for starting our push for examples. Comments noted above

@Smokrow
Copy link
Contributor Author

Smokrow commented Apr 7, 2019

@ppwwyyxx as promised the colab notebook we talked about #14 . Would you mind taking a look?

Do you know a good example we can add to showcase the axis parameter? (I tried using channels first/channels last but this will not run on colab since we have no GPU on there)

@seanpmorgan
Copy link
Member

Hmmm.. Colab should have a GPU, but our pip package has not implemented GPU kernels yet (See #118). This is also a good time to make sure that axis parameter is intuitive because @ppwwyyxx expressed concerns about it not really making sense.

@seanpmorgan
Copy link
Member

@Smokrow when time allows:

  1. Remove the duplicate notebook
  2. Move the notebook to just tensorflow_addons/examples
  3. Rename the notebook to layers_normalizations
  4. Edit the colab link to be the location the notebook will be at once it's merged.
  5. Update the content now the LayerNorm has been removed
  6. Provide an end to end example of GroupNorm vs. BatchNorm or LayerNorm from core

@Smokrow Smokrow requested a review from a team as a code owner April 23, 2019 18:05
@Smokrow
Copy link
Contributor Author

Smokrow commented Apr 28, 2019

We mark this PR as WIP until tf core adds a normalization layer. After that I will change the links in the notebook since the comparison is not working right now

@seanpmorgan seanpmorgan changed the title Colab Notebook for Normalizations [WIP] Colab Notebook for Normalizations Apr 29, 2019
@seanpmorgan
Copy link
Member

@Smokrow Just FYI this should be unblocked now that we are built against tf2-beta

@Squadrick Squadrick added the wip Work in-progress label Jun 21, 2019
@Smokrow
Copy link
Contributor Author

Smokrow commented Jun 26, 2019

@seanpmorgan
Everything seems to be working fine now
Feel free to merge.

Sry for the long wait

@seanpmorgan seanpmorgan changed the title [WIP] Colab Notebook for Normalizations Colab Notebook for Normalizations Jun 28, 2019
@seanpmorgan seanpmorgan added kokoro:force-run and removed wip Work in-progress labels Jul 1, 2019
@googlebot

This comment has been minimized.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 2, 2019
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks Moritz!

@seanpmorgan seanpmorgan merged commit d44e2a0 into tensorflow:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants