Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: StreamExecutor C API #257

Merged
merged 65 commits into from
Sep 29, 2020
Merged

RFC: StreamExecutor C API #257

merged 65 commits into from
Sep 29, 2020

Commits on Jun 12, 2020

  1. Adding StreamExecutor C API RFC

    @annarev
    annarev committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    72986fd View commit details
    Browse the repository at this point in the history

  2. Added Questions and Discussion Topics section + a few other updates

    @annarev
    annarev committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    0de0f08 View commit details
    Browse the repository at this point in the history

  3. Update title

    @annarev
    annarev committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    2e29982 View commit details
    Browse the repository at this point in the history

  4. Fix table lines by not wrapping them

    @annarev
    annarev committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    13f3811 View commit details
    Browse the repository at this point in the history

  5. Updated link and status

    @annarev
    annarev committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    e4f7b0c View commit details
    Browse the repository at this point in the history

  6. Fix table again

    @annarev
    annarev committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    9cc21e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Minor edits.

    @penpornk
    penpornk authored Jun 13, 2020
    Configuration menu
    Copy the full SHA
    a7840c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Minor fixes.

    @penpornk
    penpornk authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    cba7123 View commit details
    Browse the repository at this point in the history

  2. Change nanoseconds and microseconds values to unsigned, remove header

    @annarev
    annarev authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    1da7dc4 View commit details
    Browse the repository at this point in the history

  3. Update sentence that talks about bake-in period.

    @annarev
    annarev authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    f9a3322 View commit details
    Browse the repository at this point in the history

  4. Change updated date

    @annarev
    annarev authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    54459f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Rename TF_StreamExecutor --> SE_Device, TF_StreamExecutorFns --> SE_S… 

    …treamExecutor
    @annarev
    annarev authored Jun 23, 2020
    Configuration menu
    Copy the full SHA
    015b13a View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Update 20200612-stream-executor-c-api.md 

    Defined a portable bool type TF_BOOL.
Added structure size definitions and updated usage examples.
Fixed typos where member functions are supposed to be member function pointers.
Fixed missing extern "C".
    @yisitu
    yisitu authored Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e0baefc View commit details
    Browse the repository at this point in the history

  2. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jun 26, 2020
    Configuration menu
    Copy the full SHA
    0bef9d1 View commit details
    Browse the repository at this point in the history

  3. Link to PluggableDevice RFC.

    @penpornk
    penpornk authored Jun 26, 2020
    Configuration menu
    Copy the full SHA
    aecb20a View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jun 29, 2020
    Configuration menu
    Copy the full SHA
    d64f130 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jun 30, 2020
    Configuration menu
    Copy the full SHA
    b956b68 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from yisitu/patch-1 

    Update 20200612-stream-executor-c-api.md
    @annarev
    annarev authored Jun 30, 2020
    Configuration menu
    Copy the full SHA
    018ab65 View commit details
    Browse the repository at this point in the history

  3. Update 20200612-stream-executor-c-api.md 

    Small fix such that APIs pass const char* types.
    @yisitu
    yisitu authored Jun 30, 2020
    Configuration menu
    Copy the full SHA
    28a3904 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    5473c55 View commit details
    Browse the repository at this point in the history

  2. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    340a4de View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jul 6, 2020
    Configuration menu
    Copy the full SHA
    aca4ecb View commit details
    Browse the repository at this point in the history

  2. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jul 6, 2020
    Configuration menu
    Copy the full SHA
    49cde60 View commit details
    Browse the repository at this point in the history

  3. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jul 6, 2020
    Configuration menu
    Copy the full SHA
    22bfc8f View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Update 20200612-stream-executor-c-api.md

    @yisitu
    yisitu authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fd9573e View commit details
    Browse the repository at this point in the history

  2. Update 20200612-stream-executor-c-api.md 

    Removed timer_fns as it is not used.
    @yisitu
    yisitu authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a3e44b1 View commit details
    Browse the repository at this point in the history

  3. Update 20200612-stream-executor-c-api.md 

    Added SE_MAJOR, SE_MINOR, SE_REVISION.
    @yisitu
    yisitu authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2d530f6 View commit details
    Browse the repository at this point in the history

  4. Update 20200612-stream-executor-c-api.md 

    Updated usage of SE_TimerFns
    @yisitu
    yisitu authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4e239ea View commit details
    Browse the repository at this point in the history

  5. Update 20200612-stream-executor-c-api.md 

    Non-functional refactoring.
    @yisitu
    yisitu authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    078c7e7 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2 from yisitu/patch-2 

    Update 20200612-stream-executor-c-api.md
    @annarev
    annarev authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    59040cb View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Changed arguments to structs, added registration details

    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    caf2d1f View commit details
    Browse the repository at this point in the history

  2. Switch static initialization to fixed name 

    Fixed name function called `SE_InitializePlugin`
    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    b193e4e View commit details
    Browse the repository at this point in the history

  3. Pass SE_StreamExecutor* to create function

    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    e755690 View commit details
    Browse the repository at this point in the history

  4. Entrains --> Enqueues

    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    dda41e3 View commit details
    Browse the repository at this point in the history

  5. entrained --> enqueued

    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    d463d1f View commit details
    Browse the repository at this point in the history

  6. Added memory_space comment to allocate

    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    7c947d7 View commit details
    Browse the repository at this point in the history

  7. Clarify how StreamExecutor methods were selected

    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    a3b1518 View commit details
    Browse the repository at this point in the history

  8. Remove extra * from SE_TimerFns**

    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    f824058 View commit details
    Browse the repository at this point in the history

  9. Annotated in/out arguments for create_device/create_stream_executor 

    We should probably annotate all functions in the C API to clarify inputs and outputs. I will do that when implementing.
    @annarev
    annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    3fde302 View commit details
    Browse the repository at this point in the history

  10. Create C_API_versioning_strategy.md 

    Added details on how TensorFlow SE C API versioning works.
    @yisitu @annarev
    yisitu authored and annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    09e2313 View commit details
    Browse the repository at this point in the history

  11. Add a missing backtick.

    @penpornk @annarev
    penpornk authored and annarev committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    9053ba6 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Prefix structs with SE_ or SP_ prefixes

    @annarev
    annarev authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    539e7fa View commit details
    Browse the repository at this point in the history

  2. Missed rename SE_TimerFns --> SP_TimerFns 

    Co-authored-by: Situ Yi <60493024+yisitu@users.noreply.github.com>
    @annarev @yisitu
    annarev and yisitu authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    36784e5 View commit details
    Browse the repository at this point in the history

  3. Missed rename SE_AllocatorStats --> SP_AllocatorStats 

    Co-authored-by: Situ Yi <60493024+yisitu@users.noreply.github.com>
    @annarev @yisitu
    annarev and yisitu authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e816573 View commit details
    Browse the repository at this point in the history

  4. Missed suggestion SE_Device --> SP_Device 

    Co-authored-by: Situ Yi <60493024+yisitu@users.noreply.github.com>
    @annarev @yisitu
    annarev and yisitu authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e8291e1 View commit details
    Browse the repository at this point in the history

  5. data --> ext 

    Co-authored-by: Situ Yi <60493024+yisitu@users.noreply.github.com>
    @annarev @yisitu
    annarev and yisitu authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    3b9e27e View commit details
    Browse the repository at this point in the history

  6. Sync memcpy + more SE_/SP_ changes + support other types

    @annarev
    annarev authored Jul 16, 2020
    Configuration menu
    Copy the full SHA
    d9fc33a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Remove PlatformId

    @annarev
    annarev authored Jul 17, 2020
    Configuration menu
    Copy the full SHA
    8acf685 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Added host_memory_allocate/deallocate

    @annarev
    annarev authored Jul 23, 2020
    Configuration menu
    Copy the full SHA
    9d6383f View commit details
    Browse the repository at this point in the history

  2. uint64 --> uint64_t

    @annarev
    annarev authored Jul 23, 2020
    Configuration menu
    Copy the full SHA
    cf501f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Add device-to-device memcopies, removed extra void* ext

    @annarev
    annarev authored Aug 19, 2020
    Configuration menu
    Copy the full SHA
    31de234 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Added unified memory allocate/deallocate

    @annarev
    annarev authored Aug 20, 2020
    Configuration menu
    Copy the full SHA
    b42f06e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Change REVISION_VERSION to PATCH_VERSION 

    To be to consistent with https://www.tensorflow.org/guide/versions
    @penpornk
    penpornk authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    c8d9d00 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Merge remote-tracking branch 'annarev/stream_executor_rfc'

    @penpornk
    penpornk committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    2255854 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Update 20200612-stream-executor-c-api.md 

    * Added the Implementation Conventions and Usage Overview section.
* Replaced the Stability / User Impact with the Versioning Strategy and Stability section. Also moved the section higher.
* Updated the API design according to the real implementation.
* Updated code examples.
    @penpornk
    penpornk authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    3bb5b4d View commit details
    Browse the repository at this point in the history

  2. Added/updated versioning contents based on the discussion on the Plug… 

    …gableDevice RFC (PR tensorflow#262).

* Referenced semver and TensorFlow's Version Compatibility page.
* Added the Updating Guidelines, Convention, and Detecting Incompatibility sections.
* Merged the current code examples with @yisitu's newer ones on PR tensorflow#262 and simplified them a bit.
    @penpornk
    penpornk authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    9787cb1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/tensorflow/community into… 

    … stream_executor_rfc
    @annarev
    annarev committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    0e55bdb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'stream_executor_rfc' of github.com:annarev/community in… 

    …to stream_executor_rfc
    @annarev
    annarev committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1041176 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'annarev/stream_executor_rfc'

    @penpornk
    penpornk committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b3360a8 View commit details
    Browse the repository at this point in the history

  6. Fixes according to annarev@'s comments. 

    Also some more minor edits.
    @penpornk
    penpornk authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    d1ec351 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Situ Yi <60493024+yisitu@users.noreply.github.com>
    @penpornk @yisitu
    penpornk and yisitu authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    1a6f2cf View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Situ Yi <60493024+yisitu@users.noreply.github.com>
    @penpornk @yisitu
    penpornk and yisitu authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0218043 View commit details
    Browse the repository at this point in the history

  3. More clean-ups. 

    Changed "shall" to "must" to make sure people would not misinterpret "shall".
    @penpornk
    penpornk authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    cc0f721 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #5 from penpornk/master 

    Updates based on recent changes and discussion on RFC PR tensorflow#262
    @annarev
    annarev authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2c53747 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Custom and default allocator added

    @annarev
    annarev authored Sep 17, 2020
    Configuration menu
    Copy the full SHA
    21be6e9 View commit details
    Browse the repository at this point in the history