Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code quality: apply dart lint rules, format and remove unused imports #28

Merged
merged 1 commit into from
May 4, 2023

Conversation

mdejeans
Copy link
Contributor

@mdejeans mdejeans commented May 4, 2023

Hello everyone !

Really glad that tflite for flutter is moving forward with the little love needed for the old community plugin !

Here's some small fixes to avoid the 51 linter's warns in order to (start) improving code quality :

  • moving to UpperCamelCase style
  • remove unused imports
  • unnecessary cast
  • dart format everywhere

This is a partial copy of a personal fork of the old repo I currently use for few projects ( am15h/tflite_flutter_plugin#235 )

Happy to discuss about it 🎉

@google-cla
Copy link

google-cla bot commented May 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mdejeans mdejeans changed the title fixes: apply dart lint rules for code style and remove unused imports fixes: apply dart lint rules, format and remove unused imports May 4, 2023
@mdejeans mdejeans changed the title fixes: apply dart lint rules, format and remove unused imports code quality: apply dart lint rules, format and remove unused imports May 4, 2023
@mdejeans mdejeans marked this pull request as ready for review May 4, 2023 07:05
@PaulTR
Copy link
Collaborator

PaulTR commented May 4, 2023

LGTM. Can you also send up a PR adding your name under the AUTHORS file in the project root? Thanks!

@PaulTR PaulTR merged commit 27306cd into tensorflow:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants