Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running lint concurrently with Travis CI build #304

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

yongtang
Copy link
Member

Before this PR the Travis Ci build was set in a way such that
lint runs before any other tests (and fails immediately). See for example PR #303.

Think it makes sense to allow running lint concurrently with
other tests, so that people could fix all build failures (including lint)
in one update.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

Before this PR the Travis Ci build was set in a way such that
lint runs before any other tests (and fails immediately).

Think it makes sense to allow running lint concurrently with
other tests, so that people could fix all build failures (including lint)
in one update.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this will save some time, LGTM!

@BryanCutler BryanCutler merged commit ee2b85a into tensorflow:master Jun 17, 2019
@yongtang yongtang deleted the lint branch June 17, 2019 20:40
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
Before this PR the Travis Ci build was set in a way such that
lint runs before any other tests (and fails immediately).

Think it makes sense to allow running lint concurrently with
other tests, so that people could fix all build failures (including lint)
in one update.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants