Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --plat-name macosx_10_13_x86_64 on macos wheel build #797

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

yongtang
Copy link
Member

Add --plat-name macosx_10_13_x86_64 on macos wheel build

This is part of the effort to resolve the issue raised in tensorflow/addons#1108

We still need to find out a way to sanity check for OSX 10.13

Signed-off-by: Yong Tang yong.tang.github@outlook.com

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Copy link
Member Author

/cc @seanpmorgan FYI.

@yongtang
Copy link
Member Author

/cc @BryanCutler @terrytangyuan

@yongtang
Copy link
Member Author

Plan to merge this PR shortly.

  1. Once the PR is merged, will wait for nightly release pushed to PyPI.org.
  2. One the nightly is in PyPI.org, the other PR Add Travis CI for nightly wheel macOS build #798 will be triggered to test.
  3. If anything breaks will revert back.

@yongtang
Copy link
Member Author

Will merge and give it a try. At the minimum the wheel (label with 10_13_x86_64) should work on 10.15 any way.

@yongtang yongtang merged commit ff42b88 into tensorflow:master Feb 20, 2020
@yongtang yongtang deleted the plat-name branch February 20, 2020 05:40
@yongtang
Copy link
Member Author

The nightly build "mostly works" except a Kafka issue, which I believe is due to Blizzard/node-rdkafka#686 (comment)

The kafka issue is being worked on (though depending on some other issues confluentinc/librdkafka#2716)

Overall, building 10.13 wheel file on 10.15 is feasible. I will take a look and see if we could wire up Travis CI to do the test only.

@yongtang
Copy link
Member Author

I am getting the same error of Travis CI as https://travis-ci.community/t/create-request-permissions-suddenly-needed-but-no-information-about-it-online/7158

Not going to bother further with Travis CI, as it take too much effort to fix so many things.

But overall, we have published the 10.13 compatible wheels to PyPI.org and it works (by manually testing with Travis CI).

i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
)

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant