Add MP3 support (with minimp3) for Audio Dataset and IOTensor #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds MP3 support (with minimp3) for Audio Dataset and IOTensor. The difference between this PR and FFmpeg is that FFmpeg is only supported on specific Ubuntu 16.04 and 18.04, though external .so. This PR builds minimp3 as part of the program and support Windows/Linux/macOS. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
The error of skipping the not decodable first frames in callback mode was fixed here lieff/minimp3@2b9a023 . It's rare case, but may be worth updating. |
|
Thanks. Glad to help :) |
|
@yongtang sorry, didn't had much time recently. I update my benchmarks to include 0.12.0 and tested the minimp3 performance. Its almost factor 10 faster than ffmpeg! 🐎
|
|
@faroit Nice 👍 ! |
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
…flow#801) * Add MP3 support (with minimp3) for Audio Dataset and IOTensor This PR adds MP3 support (with minimp3) for Audio Dataset and IOTensor. The difference between this PR and FFmpeg is that FFmpeg is only supported on specific Ubuntu 16.04 and 18.04, though external .so. This PR builds minimp3 as part of the program and support Windows/Linux/macOS. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update minimp3 to carry patch on Windows Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds MP3 support (with minimp3) for Audio Dataset and IOTensor.
The difference between this PR and FFmpeg is that FFmpeg is only supported
on specific Ubuntu 16.04 and 18.04, though external .so.
This PR builds minimp3 as part of the program and support Windows/Linux/macOS.
/cc @faroit in case you might be interested.
Signed-off-by: Yong Tang yong.tang.github@outlook.com