Exclude TSL linkage to solve Windows build problem #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karllessard
added a commit
that referenced
this pull request
Feb 23, 2024
* Exclude generation of JavaCPP bindings depending on TSL * Skip C++-API dependent method * Use official 2.15 Windows C build
karllessard
added a commit
that referenced
this pull request
Feb 24, 2024
* Exclude generation of JavaCPP bindings depending on TSL * Skip C++-API dependent method * Use official 2.15 Windows C build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we are waiting for a fix to solve the Windows TSL symbols problem, it turns out that the JavaCPP bindings that were generating linkage problem with the C Lib are not being used directly by our Java API. Skipping them allows us now to build TF Java successfully on Windows. See this run:
https://github.com/karllessard/tensorflow-java/actions/runs/7876348680