Fix slicing out of order

tensorflow · Apr 20, 2023 · b86ee6e · b86ee6e
1 parent b1fe5eb
commit b86ee6e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/tfjs-core/src/io/weights_loader.ts b/tfjs-core/src/io/weights_loader.ts
@@ -399,7 +399,7 @@ function search<T>(sortedArray: T[], compare: (t: T) => number): number {
   let max = sortedArray.length;
 
   while (min <= max) {
-    const middle = Math.floor((max - min) / 2);
+    const middle = Math.floor((max - min) / 2) + min;
     const side = compare(sortedArray[middle]);
 
     if (side === 0) {

diff --git a/tfjs-core/src/io/weights_loader_test.ts b/tfjs-core/src/io/weights_loader_test.ts
@@ -597,6 +597,12 @@ describe('CompositeArrayBuffer', () => {
          expectArraysEqual(new Uint8Array(composite.slice(7, 1000)),
                            [7,8,9,10,11,12,13,14,15,16]);
        });
+
+    it(`${buffersType}: slices multiple ranges out of order`, () => {
+      expectArraysEqual(new Uint8Array(composite.slice(13, 15)), [13, 14]);
+      expectArraysEqual(new Uint8Array(composite.slice(0, 2)), [0, 1]);
+      expectArraysEqual(new Uint8Array(composite.slice(9, 13)), [9, 10, 11, 12]);
+    });
   }
 
   it('can be passed an empty arraybuffer', () => {