Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgpu: Move the readSync warning position #7724

Merged
merged 1 commit into from
May 30, 2023
Merged

webgpu: Move the readSync warning position #7724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tfjs-backend-webgpu/src/backend_webgpu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,13 +377,6 @@ export class WebGPUBackend extends KernelBackend {
}

override readSync(dataId: object): BackendValues {
if (!this.hasReadSyncWarned) {
this.hasReadSyncWarned = true;
console.warn(
`The performance of synchronously reading data from GPU to CPU is ` +
`poor on the webgpu backend, please use asynchronous APIs instead.`);
}

const tensorData = this.tensorMap.get(dataId);
const {values, complexTensorInfos} = tensorData;

Expand All @@ -403,6 +396,13 @@ export class WebGPUBackend extends KernelBackend {
return complexVals;
}

if (!this.hasReadSyncWarned) {
this.hasReadSyncWarned = true;
console.warn(
`The performance of synchronously reading data from GPU to CPU is ` +
`poor on the webgpu backend, please use asynchronous APIs instead.`);
}

const alphaModes: GPUCanvasAlphaMode[] = ['opaque', 'premultiplied'];

const buffer = tensorData.resource as GPUBuffer;
Expand Down