-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken link for MacOS Catalina guide in README.md #8032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
approved these changes
Oct 31, 2023
@pyu10055 Please take a look when you get a chance. Thanks! |
Hi @pyu10055 Any update on this PR? Please. Thank you! |
mattsoulanille
requested review from
Linchenn
and removed request for
pyu10055
November 28, 2023 20:51
Linchenn
approved these changes
Nov 28, 2023
Hi @gaikwadrahul8 Your branch is out of date, can you please update your branch? Thank you! |
1 similar comment
Hi @gaikwadrahul8 Your branch is out of date, can you please update your branch? Thank you! |
This was referenced May 31, 2024
Closed
This was referenced Jun 20, 2024
Closed
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
This was referenced Sep 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated broken link on this page for
this guide
hyperlink on this line "For Mac OS Catalina please follow this guide to install node-gyp."I checked
node-gyp
official documentation and it seems like they've removedmacOS_Catalina.md
file so either we can remove that hyperlink or point to the normal MacOS instructions to installnode-gyp
, What do you think please guide me on this. Thank you.