Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken link for MacOS Catalina guide in README.md #8032

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

gaikwadrahul8
Copy link
Contributor

@gaikwadrahul8 gaikwadrahul8 commented Oct 27, 2023

I have updated broken link on this page for this guide hyperlink on this line "For Mac OS Catalina please follow this guide to install node-gyp."

I checked node-gyp official documentation and it seems like they've removed macOS_Catalina.md file so either we can remove that hyperlink or point to the normal MacOS instructions to install node-gyp , What do you think please guide me on this. Thank you.

@mattsoulanille
Copy link
Member

@pyu10055 Please take a look when you get a chance. Thanks!

@gbaned
Copy link

gbaned commented Nov 20, 2023

Hi @pyu10055 Any update on this PR? Please. Thank you!

@mattsoulanille mattsoulanille requested review from Linchenn and removed request for pyu10055 November 28, 2023 20:51
@mattsoulanille mattsoulanille enabled auto-merge (squash) November 28, 2023 21:03
@gbaned
Copy link

gbaned commented Dec 16, 2023

Hi @gaikwadrahul8 Your branch is out of date, can you please update your branch? Thank you!

1 similar comment
@gbaned
Copy link

gbaned commented Jan 8, 2024

Hi @gaikwadrahul8 Your branch is out of date, can you please update your branch? Thank you!

@mattsoulanille mattsoulanille merged commit b004ab6 into master Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants