-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pred2bq executor refactor #222
Feature/pred2bq executor refactor #222
Conversation
Thanks for the PR! 🚀 Instructions: Approve using |
- Adds unit tests - Also adds credits to original code author
b200795
to
8a477fc
Compare
@hanneshapke @rcrowe-google if the PR looks good I was wondering if we could already merge it. I'd like to raise a subsequent PR for further code changes to the component. |
@cfezequiel I am sorry, I won't have a chance to review the PR in detail. A brief review looked good, but the PR is a bigger rewrite than what I can handle after work at the moment. I am sorry. |
@cfezequiel Just did another pass over the PR. Could you please remove my email address from the files. Can you leave my name and add my affiliation please (e.g. Happy to stamp / merge afterward. |
@hanneshapke Sure, done. |
/lgtm |
@cfezequiel Thank you. |
Approval received from @hanneshapke! ✅ PR is approved. Missing merge command to auto-merge PR! |
/merge |
Merged with approvals from hanneshapke - thanks for the contribution! 🎉 |
Thanks for the approval and merge @hanneshapke . |
Fixes #221
Refactors executor.py
Adds unit tests
Adds credits to original code author
[ X ] Tests pass