Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: answer augmentation review #48

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: answer augmentation review #48

merged 1 commit into from
Dec 11, 2024

Conversation

mediumsizeworkingdog
Copy link
Collaborator

@mediumsizeworkingdog mediumsizeworkingdog commented Dec 2, 2024 •
edited
Loading

  • renamed _merge_JS_and_HTML to lowercase
  • declare selected_topic as a Topic instead of a singleton list in synthetic.py

@mediumsizeworkingdog mediumsizeworkingdog changed the title chore: style changes chore: answer-augmentation-review Dec 2, 2024
@mediumsizeworkingdog mediumsizeworkingdog changed the title chore: answer-augmentation-review chore: answer augmentation review Dec 2, 2024
jarvis8x7b
jarvis8x7b approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@jarvis8x7b jarvis8x7b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mediumsizeworkingdog mediumsizeworkingdog merged commit 9ff9778 into dev Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarvis8x7b jarvis8x7b jarvis8x7b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mediumsizeworkingdog @jarvis8x7b