perf: refactor updating the expired status with tx, and remove task t… #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
codebender37
commented
Oct 29, 2024
•
codebender37
commented
- removed transaction in updating expired status since need to be atomic
- refactored with raw query
- delete task that are expired, and no task result
- update task's status if that are expired and has task result
codebender37
force-pushed
the
perf/remove-expired-task-with-no-task-result
branch
2 times, most recently
from
6742497 to
22e63e6
Compare
karootplx
reviewed
Nov 6, 2024
karootplx
reviewed
Nov 6, 2024
codebender37
force-pushed
the
perf/remove-expired-task-with-no-task-result
branch
from
e240535 to
5174a5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.