perf: add cache in db layer #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karootplx
reviewed
Nov 29, 2024
karootplx
reviewed
Nov 29, 2024
pkg/orm/task.go
Outdated
| if len(tc.types) > 0 { | ||
| typeStrs := make([]string, len(tc.types)) | ||
| for i, t := range tc.types { | ||
| typeStrs[i] = string(t)[0:2] // Take first 2 chars of each type |
There was a problem hiding this comment.
what happens if we have task type text_to_image and text_to_three_d? will be hard to differentiate between them right
There was a problem hiding this comment.
yep, probably better use the whole string to be safe
jarvis8x7b
requested changes
Nov 29, 2024
codebender37
force-pushed
the
perf/add-cache-in-db-layer
branch
from
387d155 to
c5a1a41
Compare
jarvis8x7b
previously approved these changes
Dec 2, 2024
codebender37
force-pushed
the
perf/add-cache-in-db-layer
branch
from
c5a1a41 to
1f0100b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.