Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bert Unsqueeze Support #12731

Closed
ntarafdar opened this issue Sep 16, 2024 · 1 comment
Closed

Bert Unsqueeze Support #12731

ntarafdar opened this issue Sep 16, 2024 · 1 comment

Comments

@ntarafdar
Copy link
Contributor

Sprint on making sure all unsqueeze configs are supported in Bert.

These are the shape.
Update the Status column for the shapes that are supported and add these shapes to unit test.

aten.unsqueeze.default

ATen Input Variations Status
0 Tensor<[1, 1, 256]> self = ?,
int<> dim = 2
Done
1 Tensor<[1, 256]> self = ?,
int<> dim = 1
Done

Should be with reshape, first try reshape on device, if that doesn't work then reshape.

@ntarafdar ntarafdar added the P0 label Sep 16, 2024
@ntarafdar ntarafdar self-assigned this Sep 16, 2024
@ntarafdar
Copy link
Contributor Author

Seems to work with reshape. going to add Unsqueeze wrapper for reshape

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants