Add Unsqueeze and more support for squeeze #12734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarafdar
requested review from
eyonland,
patrickroberts,
yan-zaretskiy,
cfjchu,
xanderchin,
TT-BrianLiu,
ayerofieiev-tt,
dmakoviichuk-tt,
razorback3,
dongjin-na and
sjameelTT
as code owners
TT-BrianLiu
approved these changes
Sep 16, 2024
ttnn/cpp/ttnn/operations/data_movement/squeeze/squeeze_pybind.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/data_movement/unsqueeze/unsqueeze_pybind.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/data_movement/unsqueeze/unsqueeze_pybind.hpp
Outdated
Show resolved
Hide resolved
sjameelTT
approved these changes
Sep 16, 2024
ntarafdar
force-pushed
the
tarafdarTT/unsqueeze
branch
from
b71260e
to
cf98928
Compare
ntarafdar
force-pushed
the
tarafdarTT/unsqueeze
branch
from
8168414
to
c8a19a3
Compare
ayerofieiev-tt
approved these changes
Sep 18, 2024
ntarafdar
force-pushed
the
tarafdarTT/unsqueeze
branch
from
0177fb7
to
189cc2f
Compare
ntarafdar
commented
Sep 20, 2024
| ) | ||
| def squeeze(tensor, dim): | ||
| r"""squeeze(tensor: ttnn.Tensor, dim: int) -> ttnn.Tensor""" | ||
| if dim != 0: |
There was a problem hiding this comment.
@ayerofieiev-tt
This was removed,
We could add this back and only handle dim != 0 using the new stuff and handle dim==0 here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
There's no Unsqueeze support in ttnn. there's also squeeze but only in python with limited support
What's changed
Added Unsqueeze and squeeze as wrappers to reshape
Checklist