Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle data collection cases where artifacts aren't carried over between attempts #12840

Closed
Tracked by #10718
tt-rkim opened this issue Sep 18, 2024 · 2 comments
Closed
Tracked by #10718

Handle data collection cases where artifacts aren't carried over between attempts #12840

tt-rkim opened this issue Sep 18, 2024 · 2 comments
Assignees
@tt-rkim
Labels
data-collection collab ticket with data science team infra-ci infrastructure and/or CI changes P1

Comments

@tt-rkim
Copy link
Collaborator

tt-rkim commented Sep 18, 2024

No description provided.

@tt-rkim tt-rkim mentioned this issue Sep 18, 2024
Open
31 tasks
@tt-rkim
Copy link
Collaborator Author

tt-rkim commented Sep 18, 2024

ex. https://github.com/tenstorrent/tt-metal/actions/runs/10085445285

@tt-rkim tt-rkim changed the title artifacts aren't carried over between attempts ex. https://github.com/tenstorrent/tt-metal/actions/runs/10085445285 Handle data collection cases where artifacts aren't carried over between attempts Sep 18, 2024
@tt-rkim tt-rkim self-assigned this Sep 18, 2024
@tt-rkim tt-rkim added infra-ci infrastructure and/or CI changes P1 data-collection collab ticket with data science team labels Sep 18, 2024
tt-rkim added a commit that referenced this issue Sep 18, 2024
@tt-rkim
#12840: Add support for artifacts for multiple attempts by downloadin…
7a6b636 
…g all of them, so that the system doesn't get confused when searching for artifacts that were generated in a previous attempt but weren't carried over
tt-rkim added a commit that referenced this issue Sep 18, 2024
@tt-rkim
#12840: Instead of using trying to match all the job IDs found in the…
3564a6d 
… downloaded logs to a test report, only match the ones for the requested job, so we don't handle more than we need to and run into issues such as what we currently have where multiple attempts of a workflow run will cause multiple github_job_ids to have the same uuid, meaning we can't match later because we lose data
@tt-rkim tt-rkim mentioned this issue Sep 18, 2024
Merged
5 tasks
tt-rkim added a commit that referenced this issue Sep 18, 2024
@tt-rkim
#12840: Add support for artifacts for multiple attempts by downloadin…
73139ef 
…g all of them, so that the system doesn't get confused when searching for artifacts that were generated in a previous attempt but weren't carried over
tt-rkim added a commit that referenced this issue Sep 18, 2024
@tt-rkim
#12840: Instead of using trying to match all the job IDs found in the…
1a361c2 
… downloaded logs to a test report, only match the ones for the requested job, so we don't handle more than we need to and run into issues such as what we currently have where multiple attempts of a workflow run will cause multiple github_job_ids to have the same uuid, meaning we can't match later because we lose data
tt-rkim added a commit that referenced this issue Sep 18, 2024
@tt-rkim
#12840: Add more handling more multiple attempts by restricting the s…
ea8522c 
…pace of `github_job_id`s we're looking to only the ones in the workflow run attempt in question (#12858)

* #12840: Add support for artifacts for multiple attempts by downloading all of them, so that the system doesn't get confused when searching for artifacts that were generated in a previous attempt but weren't carried over

* #12840: Instead of using trying to match all the job IDs found in the downloaded logs to a test report, only match the ones for the requested job, so we don't handle more than we need to and run into issues such as what we currently have where multiple attempts of a workflow run will cause multiple github_job_ids to have the same uuid, meaning we can't match later because we lose data
@tt-rkim
Copy link
Collaborator Author

tt-rkim commented Sep 19, 2024

Good now!

github_job_id -> uuid is the correct mapping when looking at logs... not sure why we did it the other way before. I must have been on something.

@tt-rkim tt-rkim closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tt-rkim tt-rkim

Labels
data-collection collab ticket with data science team infra-ci infrastructure and/or CI changes P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tt-rkim