Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unit tests and related test infrastructure for the data collection tools so we can have better refactoring flexibility later #12885

Closed
Tracked by #10718
tt-rkim opened this issue Sep 19, 2024 · 1 comment
Closed
Tracked by #10718

Create unit tests and related test infrastructure for the data collection tools so we can have better refactoring flexibility later #12885

tt-rkim opened this issue Sep 19, 2024 · 1 comment
Assignees
@tt-rkim
Labels
data-collection collab ticket with data science team infra-ci infrastructure and/or CI changes P2

Comments

@tt-rkim
Copy link
Collaborator

tt-rkim commented Sep 19, 2024

No description provided.

@tt-rkim tt-rkim mentioned this issue Sep 19, 2024
Open
31 tasks
@tt-rkim tt-rkim changed the title Unit tests for the infra itself so we can have better refactoring flexibility later Create unit tests and related test infrastructure for the data collection tools so we can have better refactoring flexibility later Sep 19, 2024
@tt-rkim tt-rkim added infra-ci infrastructure and/or CI changes P1 data-collection collab ticket with data science team labels Sep 19, 2024
@tt-rkim tt-rkim self-assigned this Sep 19, 2024
tt-rkim added a commit that referenced this issue Sep 19, 2024
@tt-rkim
#12885: Extract out state like workflow_outputs_dir and json file cre…
2601ecf 
…ation higher up so that unit testing becomes more convenient
tt-rkim added a commit that referenced this issue Sep 19, 2024
@tt-rkim
#12885: Fix datetime call
d4fdbb2
tt-rkim added a commit that referenced this issue Sep 19, 2024
@tt-rkim
#12885: No return
d9a8319
tt-rkim added a commit that referenced this issue Sep 19, 2024
@tt-rkim
#12885: Get pipeline id
caa9360
tt-rkim added a commit that referenced this issue Sep 19, 2024
@tt-rkim
#12885: Wrong var name
eebe95d
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Extract out state like workflow_outputs_dir and json file cre…
8438892 
…ation higher up so that unit testing becomes more convenient
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Fix datetime call
befb7b4
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: No return
1e7fde1
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Get pipeline id
b2a194a
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Wrong var name
3ae337a
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Add initial test for normal happy case with manicured data
12f9341
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Add workflow for data collection tests
cf3842a
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: REVERT ME - add trigger for this branch
4ae0ddf
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: get rid of extra step
e2d6199
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Add pytest to infra requirements
49431cc
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: rename step to test instead of incorrect description
4d79503
@tt-rkim tt-rkim mentioned this issue Sep 20, 2024
Merged
5 tasks
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Add pull request triggers and rename
5401995
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Ignore infra files for copyright
7da08cc
tt-rkim added a commit that referenced this issue Sep 20, 2024
@tt-rkim
#12885: Add initial unit tests for infra, specifically for data colle…
61329eb 
…ction (#12933)

* #12885: Extract out state like workflow_outputs_dir and json file creation higher up so that unit testing becomes more convenient

* #12885: Fix datetime call

* #12885: No return

* #12885: Get pipeline id

* #12885: Wrong var name

* #12885: Add initial test for normal happy case with manicured data

* #12885: Add workflow for data collection tests

* #12885: REVERT ME - add trigger for this branch

* #12885: get rid of extra step

* #12885: Add pytest to infra requirements

* #12885: rename step to test instead of incorrect description

* #12885: Add pull request triggers and rename

* #12885: Ignore infra files for copyright
@tt-rkim
Copy link
Collaborator Author

tt-rkim commented Sep 20, 2024

other good cases to add:

https://github.com/tenstorrent/tt-metal/actions/runs/10944692193
https://github.com/tenstorrent/tt-metal/actions/runs/10931627385/job/30346948102
https://github.com/tenstorrent/tt-metal/actions/runs/10931660646/job/30347033623
https://github.com/tenstorrent/tt-metal/actions/runs/10931661870/job/30347039084
https://github.com/tenstorrent/tt-metal/actions/runs/10931662820/job/30347042819
https://github.com/tenstorrent/tt-metal/actions/runs/10931665058/job/30347048284

@tt-rkim tt-rkim added P2 and removed P1 labels Sep 23, 2024
@tt-rkim tt-rkim closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tt-rkim tt-rkim

Labels
data-collection collab ticket with data science team infra-ci infrastructure and/or CI changes P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tt-rkim