Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FD2.1 finish cleanup of runtime address map (use dynamic address map) #4984

Closed
pgkeller opened this issue Jan 26, 2024 · 1 comment
Closed

FD2.1 finish cleanup of runtime address map (use dynamic address map) #4984

pgkeller opened this issue Jan 26, 2024 · 1 comment
Assignees
@pgkeller
Labels
feature feature-request External feature request P1

Comments

@pgkeller
Copy link
Contributor

pgkeller commented Jan 26, 2024 •
edited
Loading

Finish cleaning up the address map, started under #403. Including but not limited to:

  • move to dynamic locations specified in launch message for, eg, CBs, runtime args, binaries, etc
  • remove dead items (eg, graph interpreter)
  • remove common_runtime_address_map.h

Also, kernel binaries and local data memory are currently written to the device as 2 separate spans, these could be packed to reduce dispatch overhead
@pgkeller pgkeller added feature-request External feature request P1 labels Jan 26, 2024
@pgkeller pgkeller self-assigned this Jan 26, 2024
pgkeller added a commit that referenced this issue Jan 26, 2024
@pgkeller
#4984: Remove dead OP_INFO and graph interpreter
d6aa318
pgkeller added a commit that referenced this issue Jan 28, 2024
@pgkeller
#4984: Remove dead OP_INFO and graph interpreter
e77268f
pgkeller added a commit that referenced this issue Jan 28, 2024
@pgkeller
#4984: Remove dead OP_INFO and graph interpreter
c49a0da
pgkeller added a commit that referenced this issue Jan 29, 2024
@pgkeller
#4984: Remove unused dprint functionality
a57ea82
pgkeller added a commit that referenced this issue Jan 29, 2024
@pgkeller
#4984: Remove unused dprint functionality
522c178
pgkeller added a commit that referenced this issue Jan 29, 2024
@pgkeller
#4984: Remove unused dprint functionality
2d3a098
pgkeller added a commit that referenced this issue Jan 29, 2024
@pgkeller
#4984: Remove unused dprint functionality
ead90c3
vtangTT pushed a commit that referenced this issue Jan 31, 2024
@pgkeller @vtangTT
#4984: Remove dead OP_INFO and graph interpreter
72f6a62
vtangTT pushed a commit that referenced this issue Jan 31, 2024
@pgkeller @vtangTT
#4984: Remove unused dprint functionality
fdda00a
@pgkeller pgkeller changed the title finish cleanup of runtime address map finish cleanup of runtime address map (use dynamic address map) Feb 13, 2024
@davorchap davorchap added P2 and removed P1 labels Mar 23, 2024
@pgkeller pgkeller changed the title finish cleanup of runtime address map (use dynamic address map) FD2.1 finish cleanup of runtime address map (use dynamic address map) Apr 13, 2024
@pgkeller pgkeller added P1 and removed P2 labels Jul 25, 2024
pgkeller added a commit that referenced this issue Jul 29, 2024
@pgkeller
#4984: Add multiple spans test to test_pgm_dispatch
fce60b9
pgkeller added a commit that referenced this issue Jul 29, 2024
@pgkeller
#4984: Remove zeros from the memory map
bfedec4 
Unused
pgkeller added a commit that referenced this issue Jul 29, 2024
@pgkeller
#4984: Remove zeros from the memory map
9440f05 
Unused
pgkeller added a commit that referenced this issue Jul 29, 2024
@pgkeller
#4984: Reclaim some mem map space->ring buffer
49ccb64 
Turns out ZEROS is still used, so couldn't reclaim that
This reduces the dead space at low memory and fixes a hack in watcher for
determining hex value of the jump insn at address 0
pgkeller added a commit that referenced this issue Jul 30, 2024
@pgkeller
#4984: Consolidate linker scripts
86c0d09 
In prep for having firmware/kernel specific linker scripts
pgkeller added a commit that referenced this issue Jul 30, 2024
@pgkeller
#4984: Add multiple spans test to test_pgm_dispatch
e2352e0
pgkeller added a commit that referenced this issue Jul 30, 2024
@pgkeller
#4984: Reclaim some mem map space->ring buffer
8f8e55e 
Turns out ZEROS is still used, so couldn't reclaim that
This reduces the dead space at low memory and fixes a hack in watcher for
determining hex value of the jump insn at address 0
pgkeller added a commit that referenced this issue Jul 30, 2024
@pgkeller
#4984: Consolidate linker scripts
9efaaf9 
In prep for having firmware/kernel specific linker scripts
mo-tenstorrent added a commit that referenced this issue Sep 12, 2024
@mo-tenstorrent
#4984: Use globals for data and control arrays
0139abb
mo-tenstorrent added a commit that referenced this issue Sep 12, 2024
@mo-tenstorrent
#4984: Fix addressing issues on eth cores
3173264
mo-tenstorrent added a commit that referenced this issue Sep 12, 2024
@mo-tenstorrent
#4984: Align mailbox and profiler with BH NOC Alignment
6f4dfa1
mo-tenstorrent added a commit that referenced this issue Sep 12, 2024
@mo-tenstorrent
#4984: Addd BH to custom test dispatch
76f7a71
mo-tenstorrent added a commit that referenced this issue Sep 12, 2024
@mo-tenstorrent
#4984: Revert to 16bit alignment
bae3b81
mo-tenstorrent added a commit that referenced this issue Sep 12, 2024
@mo-tenstorrent
#4984: Fix L1_KERNEL_CONFIG_BASE
4e5757d
mo-tenstorrent added a commit that referenced this issue Sep 12, 2024
@mo-tenstorrent
#4984: Fix L1_KERNEL_CONFIG_BASE
a80407c
mo-tenstorrent pushed a commit that referenced this issue Sep 13, 2024
@pgkeller @mo-tenstorrent
#4984: Update storage core addr to mailbox base
c1ca529 
Storage cores used to include mailboxes for the L1 barrier
L1 barrier is no longer in the mailboxes, so update the base
address to the base of the mailboxes
mo-tenstorrent pushed a commit that referenced this issue Sep 13, 2024
@pgkeller @mo-tenstorrent
#4984: Move profiler buffers to mailboxes
302ad61 
And out of the common runtime address map
mo-tenstorrent added a commit that referenced this issue Sep 13, 2024
@mo-tenstorrent
#4984: Use globals for data and control arrays
071a909
mo-tenstorrent added a commit that referenced this issue Sep 13, 2024
@mo-tenstorrent
#4984: Fix addressing issues on eth cores
d0669b0
mo-tenstorrent added a commit that referenced this issue Sep 13, 2024
@mo-tenstorrent
#4984: Align mailbox's launch and profiler fields with 16B NOC Alignment
36b8f47
mo-tenstorrent added a commit that referenced this issue Sep 13, 2024
@mo-tenstorrent
#4984: 16B align mailbox's launch and profiler fields
38e1832
pgkeller added a commit that referenced this issue Sep 15, 2024
@pgkeller
#4984: Update storage core addr to mailbox base
d04c06b 
Storage cores used to include mailboxes for the L1 barrier
L1 barrier is no longer in the mailboxes, so update the base
address to the base of the mailboxes
pgkeller added a commit that referenced this issue Sep 15, 2024
@pgkeller
#4984: Move profiler buffers to mailboxes
c4ba250 
And out of the common runtime address map
pgkeller pushed a commit that referenced this issue Sep 15, 2024
@mo-tenstorrent @pgkeller
#4984: Use globals for data and control arrays
8706be3
pgkeller pushed a commit that referenced this issue Sep 15, 2024
@mo-tenstorrent @pgkeller
#4984: Fix addressing issues on eth cores
cf7cb24
pgkeller pushed a commit that referenced this issue Sep 15, 2024
@mo-tenstorrent @pgkeller
#4984: 16B align mailbox's launch and profiler fields
ebae03a
pgkeller added a commit that referenced this issue Sep 16, 2024
@pgkeller
#4984: Update storage core addr to mailbox base
9f37e58 
Storage cores used to include mailboxes for the L1 barrier
L1 barrier is no longer in the mailboxes, so update the base
address to the base of the mailboxes
pgkeller added a commit that referenced this issue Sep 16, 2024
@pgkeller
#4984: Move profiler buffers to mailboxes
8e1aed7 
And out of the common runtime address map
pgkeller pushed a commit that referenced this issue Sep 16, 2024
@mo-tenstorrent @pgkeller
#4984: Use globals for data and control arrays
5000574
pgkeller pushed a commit that referenced this issue Sep 16, 2024
@mo-tenstorrent @pgkeller
#4984: Fix addressing issues on eth cores
648cd4e
pgkeller pushed a commit that referenced this issue Sep 16, 2024
@mo-tenstorrent @pgkeller
#4984: 16B align mailbox's launch and profiler fields
ff6513d
pgkeller added a commit that referenced this issue Sep 16, 2024
@pgkeller
#4984: Update storage core addr to mailbox base
9d7191d 
Storage cores used to include mailboxes for the L1 barrier
L1 barrier is no longer in the mailboxes, so update the base
address to the base of the mailboxes
pgkeller added a commit that referenced this issue Sep 16, 2024
@pgkeller
#4984: Move profiler buffers to mailboxes
70363af 
And out of the common runtime address map
pgkeller pushed a commit that referenced this issue Sep 16, 2024
@mo-tenstorrent @pgkeller
#4984: Use globals for data and control arrays
3038e37
pgkeller pushed a commit that referenced this issue Sep 16, 2024
@mo-tenstorrent @pgkeller
#4984: Fix addressing issues on eth cores
38278f9
pgkeller pushed a commit that referenced this issue Sep 16, 2024
@mo-tenstorrent @pgkeller
#4984: 16B align mailbox's launch and profiler fields
044b9a8
@pgkeller
Copy link
Contributor Author

This is effectively done other than the last steps of cleanup w/ the hal. Closing, will open other issues for the remaining work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgkeller pgkeller

Labels
feature feature-request External feature request P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davorchap @pgkeller @jliangTT