-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add llama galaxy mlp to TG frequent tests #10274
Conversation
c344d23
to
2583e3e
Compare
a9a8253
to
e4de0a2
Compare
I'm not sure if we have a folder naming convention, should new folder be named tg or TG? |
@uaydonat Is the folder name TG under demos good for now? |
one reason why i bring this up is because we have a scripts/tg folder*
one reason why i bring this up is because we have a scripts/tg folder* |
Hi @ttmchiou looking at other folder names i think it does make more sense to use lowercase, naming have be fixed |
8fd8af2
to
11099fa
Compare
dc0701f
to
07f14bc
Compare
@@ -7,6 +7,8 @@ run_tg_tests() { | |||
echo "LOG_METAL: running run_tg_frequent_tests" | |||
|
|||
pytest tests/ttnn/multichip_unit_tests/test_multidevice_TG.py | |||
pytest models/demos/tg/llama3_70b/tests/test_llama_mlp_galaxy.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should use pytest -n auto
to use xdist and better timeout in these pipelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To further expand on @vtangTT 's point
It would be good to expand the usage of xdist across all pytests being called for all model tests going forward.
This method lets us catch and handle hanging tests better and better control timeouts. (using xdist would discourage the use of pytest.skip() at the lower level)
Example reference call below.
pytest -n auto models/demos/falcon7b/tests/test_perplexity_falcon.py::test_perplexity[True-prefill_seq1024_dram] --timeout=1800 ; fail+=$?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified all pytest calls to use xdist and timeouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… Matmul tests in test_multidevice_TG
…ma galaxy attention
a433201
to
59ff576
Compare
Ticket
#9476
Problem description
We want to add llama galaxy mlp tests to TG frequent
What's changed
Checklist