#10718: Fix issue with negative pipeline queue times #12010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt time because that means that it's a re-run and we need to account for already-passing jobs
tt-rkim
force-pushed
the
rkim/10718-no-negative-pipeline-queues
branch
from
cd66e3d
to
81451d7
Compare
|
Production: https://github.com/tenstorrent/tt-metal/actions/runs/10604279901 for pipeline https://github.com/tenstorrent/tt-metal/actions/runs/10584906061 attempt 2 worked timestamps seem to make sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#10718
Problem description
We see certain pipelines in the CI/CD dashboard come up with negative queue times. This obviously makes no sense.
The reason why this happens is because we're grabbing a job with a start time that's earlier than the pipeline queue time. How is that possible? This is because workflow re-runs can inherit already-run jobs from a previous attempt, meaning later attempts can have jobs with timestamps that are earlier than the attempt start time.
What's changed
We just filter out any jobs that have a start time earlier than the pipeline queue time. We can be confident those are jobs that from an earlier attempt.
Checklist