#12376: Support for non-32 Height in Width Sharded Conv2d #12382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
mywoodstock
reviewed
Sep 11, 2024
| (256, 2048, 8, 8, 3, 3, 1, 1, 8), | ||
| (512, 2048, 16, 16, 3, 3, 1, 1, 4), | ||
| (768, 768, 8, 8, 3, 3, 1, 1, 1), | ||
| (768, 768, 16, 16, 3, 3, 1, 1, 1), | ||
| (1280, 1280, 16, 16, 3, 3, 1, 1, 1), |
There was a problem hiding this comment.
why removed these test cases?
| @@ -204,13 +204,13 @@ OptimizedConvParallelizationConfig determine_conv_op_parallel_config_from_conv_o | |||
| TT_ASSERT(conv_output_mem_config.shard_spec.has_value()); | |||
| const auto& shard_spec = conv_output_mem_config.shard_spec.value(); | |||
| const auto& shard_shape = shard_spec.shape; | |||
| TT_ASSERT(shard_shape[0] % 32 == 0); | |||
| // TT_ASSERT(shard_shape[0] % 32 == 0); | |||
There was a problem hiding this comment.
does this affect height and block sharding variants?
bbradelTT
reviewed
Sep 11, 2024
| @@ -317,18 +317,21 @@ def run_conv_with_split( | |||
| assert_with_pcc(torch_output_tensor, torch_out_golden_tensor, pcc=pcc) | |||
|
|
|||
|
|
|||
| @skip_for_grayskull() | |||
There was a problem hiding this comment.
Do other tests cover these test scenarios on grayskull?
If not, why would these test scenarios note be relevant for grayskull?
There was a problem hiding this comment.
We are not planning on supporting these new features on gray skull.
There was a problem hiding this comment.
Are the cases in the already existing test (before this PR) supported by grayskull?
There was a problem hiding this comment.
Most of them were skipped, due to an OOM error. The width sharded Conv2d which is tested by this code was implemented to support a wormhole only model.
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
sankarmanoj-tt
temporarily deployed
to
production
GitHub Actions
Inactive
bbradelTT
approved these changes
Sep 12, 2024
mywoodstock
approved these changes
Sep 12, 2024
sankarmanoj-tt
force-pushed
the
smanoj/conv_ws_non32h
branch
from
622a8c5
to
0441bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12376
Problem description
Support for non-32 Height in Width Sharded Conv2d
Checklist