-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce scatter perf sweep #12391
Merged
Merged
Reduce scatter perf sweep #12391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caixunshiren
requested review from
eyonland,
patrickroberts,
yan-zaretskiy,
cfjchu,
xanderchin,
TT-BrianLiu,
ayerofieiev-tt,
dmakoviichuk-tt,
razorback3,
dongjin-na and
SeanNijjar
as code owners
September 9, 2024 13:12
caixunshiren
force-pushed
the
reduce-scatter-perf-sweep
branch
from
September 16, 2024 19:07
8e988a9
to
f2e1bb8
Compare
SeanNijjar
approved these changes
Sep 16, 2024
ttnn/cpp/ttnn/operations/ccl/reduce_scatter/reduce_scatter_pybind.cpp
Outdated
Show resolved
Hide resolved
caixunshiren
force-pushed
the
reduce-scatter-perf-sweep
branch
from
September 16, 2024 22:22
0335a7e
to
bb258b8
Compare
caixunshiren
force-pushed
the
reduce-scatter-perf-sweep
branch
from
September 17, 2024 13:08
bb258b8
to
e588d11
Compare
TT-BrianLiu
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Please take a look
ttnn/cpp/ttnn/operations/ccl/reduce_scatter/device/host/reduce_scatter_full_worker_grid.cpp
Outdated
Show resolved
Hide resolved
eyonland
approved these changes
Sep 17, 2024
caixunshiren
force-pushed
the
reduce-scatter-perf-sweep
branch
from
September 17, 2024 15:52
e588d11
to
a80817e
Compare
…nd added perf sweep test case
caixunshiren
force-pushed
the
reduce-scatter-perf-sweep
branch
from
September 17, 2024 15:52
a80817e
to
d9743d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#11856
Problem description
Expose num workers and num buffers in reduce scatter at op level and added perf sweep test