#12524: Update fmt and unify logging API #12464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-zaretskiy
requested review from
TT-BrianLiu,
yugaoTT,
tt-aho,
SeanNijjar,
ntarafdar,
sjameelTT,
patrickroberts,
eyonland,
bbradelTT,
mywoodstock,
shwetankTT,
sankarmanoj-tt,
pavlejosipovic,
cfjchu,
xanderchin,
razorback3,
dongjin-na,
ayerofieiev-tt,
dmakoviichuk-tt,
abhullar-tt,
pgkeller,
aliuTT,
tt-dma,
tt-asaigal,
ubcheema and
davorchap
as code owners
bbradelTT
approved these changes
Sep 10, 2024
mywoodstock
approved these changes
Sep 11, 2024
tt-aho
approved these changes
Sep 11, 2024
yan-zaretskiy
changed the title
patrickroberts
approved these changes
Sep 11, 2024
yan-zaretskiy
force-pushed
the
yan-zaretskiy/remove-fmt-runtime
branch
from
5d5ae1a
to
e6eb9c2
Compare
yan-zaretskiy
force-pushed
the
yan-zaretskiy/remove-fmt-runtime
branch
from
e6eb9c2
to
648d170
Compare
yan-zaretskiy
force-pushed
the
yan-zaretskiy/remove-fmt-runtime
branch
from
648d170
to
dca78f6
Compare
|
@razorback3 @dongjin-na Could I get you approval for this PR? |
ayerofieiev-tt
approved these changes
Sep 12, 2024
Our logging macros accept variadic arguments and print them as-is, requiring callers to use fmt::format to prepare the arguments. But the low-level log_fatal, log_warning and so on functions accept a runtime format string. This PR unifies the logging API by requiring users to always specify a valid format string, and avoids runtime formatting.
yan-zaretskiy
force-pushed
the
yan-zaretskiy/remove-fmt-runtime
branch
from
dca78f6
to
e7e3e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#12524
Problem description
Our logging macros accept variadic arguments and print them as-is, requiring callers to use fmt::format to prepare the arguments. But the low-level functions (log_fatal, log_warning and so on) accept a runtime format string.
What's changed
This PR unifies the logging API by requiring users to always specify a valid format string, and avoids runtime formatting. To achieve this, I had to update the vendored fmt version. It now matches the version used by UMD.
Checklist