[New Op] Added dropout unary op #12474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakoviichuk-tt
requested review from
patrickroberts,
yan-zaretskiy and
eyonland
as code owners
| @@ -278,6 +290,39 @@ Tensor Softplus::invoke( | |||
| optional_output_tensor); | |||
| } | |||
|
|
|||
| Tensor Dropout::invoke( | |||
There was a problem hiding this comment.
Wdyt about extracting this to its own .hpp/cpp?
There was a problem hiding this comment.
Don't want to do it right now. It is implemented the same way as any other op and uses its infra.
dmakoviichuk-tt
changed the title
dmakoviichuk-tt
requested review from
cfjchu,
xanderchin and
TT-BrianLiu
as code owners
rfurko-tt
reviewed
Sep 11, 2024
ttnn/cpp/ttnn/operations/eltwise/unary/common/unary_op_utils.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/eltwise/unary/common/unary_op_utils.cpp
Outdated
Show resolved
Hide resolved
| return detail::unary_impl( | ||
| DefaultQueueId, | ||
| input, | ||
| {UnaryWithParam{UnaryOpType::DROPOUT, {static_cast<float>(seed), probability, scale}}}, |
There was a problem hiding this comment.
why seed needs to be float?
There was a problem hiding this comment.
cc @ayerofieiev-tt ahahah :-D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
None
Problem description
I've found that we have lkk kernel but no unary dropout.
What's changed
Added unary op: dropout.
Added usage example.
Unfortunately reproducibility is low. I was able to get same results twice only if I reset device between calls.
I implemented using_dropout.py example but didn't add tests because I cannot get the same result twice.
Feedback to the kernel team was provided.
Also std is pretty high but I can use it.
Comparison vs pytorch:
https://github.com/tenstorrent/tt-metal/actions/runs/10874629279
Checklist