Contiguous pages support in Reduce Scatter read/write #12477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoraTT
force-pushed
the
avora/contig_optim
branch
from
fdcdc8d
to
7abf851
Compare
SeanNijjar
approved these changes
Sep 10, 2024
| @@ -127,24 +127,30 @@ inline void advance_worker_global_page_interleaved ( | |||
|
|
|||
| coord_t const &tensor_shape, // full tensor shape | |||
|
|
|||
| bool &last_page_of_worker | |||
| bool &last_page_of_worker, | |||
| const uint32_t stride=1 | |||
There was a problem hiding this comment.
Since this appears to be called only in one place, can we just remove the default value and then also keep last_page_of_worker last? It's a bit of a nitpick but since last_page_of_worker is purely for debug, it'll be nice to keep it separate
avoraTT
force-pushed
the
avora/contig_optim
branch
from
a08c1dc
to
698c505
Compare
avoraTT
force-pushed
the
avora/contig_optim
branch
from
698c505
to
77b3fee
Compare
…educe scatter read/write wrapped functions.
avoraTT
force-pushed
the
avora/contig_optim
branch
from
77b3fee
to
0f9654d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Problem description
Currently, the read/write chunk functions used in reduce scatter read in pages/tiles one at a time. An optimization is to instead read n contiguous pages until the end of the row, with respect to the dimensions of the shard, tensor slice, and worker slice.
What's changed
The read/write chunk functions have been updated to use the optimized shard tensor addr generators, that return the number of contiguous pages until the end of the shard. Using this, we can now read/write in a contiguous fashion until the end of the row.
Checklist