-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#0: Point UMD back to main
instead of metal-main
#12478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtangTT
force-pushed
the
vtangTT/umd_update
branch
from
September 10, 2024 20:43
8cbc7f8
to
8658364
Compare
vtangTT
force-pushed
the
vtangTT/umd_update
branch
from
September 13, 2024 15:53
92b1a6c
to
8030a86
Compare
vtangTT
force-pushed
the
vtangTT/umd_update
branch
from
September 13, 2024 17:31
8030a86
to
e483825
Compare
vtangTT
force-pushed
the
vtangTT/umd_update
branch
from
September 13, 2024 19:06
e483825
to
df2c17c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
As per slack discussion with @joelsmithTT @bojan_rosko, metal is the main consumer of UMD so it should point to main instead of a branch. This PR basically reverts #12097.
The version of UMD is basically the same.
What's changed
Pointing metal to umd
main
instead ofmetal-main
branchRelated UMD PR: tenstorrent/tt-umd#41
Checklist