Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12439: Migrate moreh_nll_loss_bwd operations (reduced and unreduced) from tt_eager to ttnn #12494

Merged
merged 10 commits into from
Sep 13, 2024
Merged

#12439: Migrate moreh_nll_loss_bwd operations (reduced and unreduced) from tt_eager to ttnn #12494

merged 10 commits into from
Sep 13, 2024

Conversation

BuiChiTrung
Copy link
Contributor

Ticket

Link to Github Issue: #12439

Problem description

moreh_nll_loss_bwd was deprecated alongside tt_dnn. This PR ports it to ttnn using its operation format.

What's changed

  • Removed moreh_nll_loss_bwd's tt_dnn implementations
  • Move device code to ttnn
  • Create new wrapper code for ttnn with new modules

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@BuiChiTrung BuiChiTrung self-assigned this Sep 11, 2024
@BuiChiTrung BuiChiTrung added the moreh moreh contribution label Sep 11, 2024
@BuiChiTrung BuiChiTrung marked this pull request as ready for review September 11, 2024 08:23
@BuiChiTrung BuiChiTrung merged commit 5775712 into main Sep 13, 2024
105 checks passed
@BuiChiTrung BuiChiTrung deleted the trungbc/nll-loss-bwd branch September 13, 2024 08:41
@BuiChiTrung BuiChiTrung mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@hschoi4448 hschoi4448 hschoi4448 approved these changes

@razorback3 razorback3 razorback3 approved these changes

@eyonland eyonland Awaiting requested review from eyonland eyonland is a code owner

@patrickroberts patrickroberts Awaiting requested review from patrickroberts patrickroberts is a code owner

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy yan-zaretskiy is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho

@mywoodstock mywoodstock Awaiting requested review from mywoodstock

Assignees

@BuiChiTrung BuiChiTrung

Labels
moreh moreh contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BuiChiTrung @razorback3 @hschoi4448 @ayerofieiev-tt