Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12497: ttnn.empty to use create_device_tensor #12542

Merged
merged 1 commit into from
Sep 17, 2024
Merged

#12497: ttnn.empty to use create_device_tensor #12542

merged 1 commit into from
Sep 17, 2024

Conversation

KalaivaniMCW
Copy link
Contributor

@KalaivaniMCW KalaivaniMCW commented Sep 11, 2024 •
edited
Loading

Ticket

Link to Github Issue #12497

Problem description

ttnn.empty creates a zeros tensor

What's changed

ttnn.empty to use create_device_tensor to create a device tensor instead of creating a zeros tensor.

Checklist

Aswinmcw
Aswinmcw approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KalaivaniMCW KalaivaniMCW marked this pull request as ready for review September 12, 2024 13:04
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/ttnn_empty_op branch 2 times, most recently from 5d55898 to 78fc95c Compare September 16, 2024 18:35
@KalaivaniMCW KalaivaniMCW merged commit 44cc7fc into main Sep 17, 2024
105 checks passed
@KalaivaniMCW KalaivaniMCW deleted the kalaivani/ttnn_empty_op branch September 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcw-anasuya mcw-anasuya mcw-anasuya approved these changes

@Aswinmcw Aswinmcw Aswinmcw approved these changes

@VirdhatchaniKN VirdhatchaniKN VirdhatchaniKN approved these changes

@tt-aho tt-aho tt-aho approved these changes

@eyonland eyonland eyonland approved these changes

@mouliraj-mcw mouliraj-mcw Awaiting requested review from mouliraj-mcw

@patrickroberts patrickroberts Awaiting requested review from patrickroberts

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KalaivaniMCW @eyonland @tt-aho @VirdhatchaniKN @Aswinmcw @mcw-anasuya