Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Update fmt and unify logging API #12587

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

yan-zaretskiy
Copy link
Contributor

Fixing the build failure, missing files from the previous commit.

Our logging macros accept variadic arguments and print them as-is,
requiring callers to use fmt::format to prepare the arguments. But the
low-level log_fatal, log_warning and so on functions accept a runtime
format string.

This PR unifies the logging API by requiring users to always specify a
valid format string, and avoids runtime formatting.
@TT-billteng TT-billteng merged commit be53f57 into main Sep 12, 2024
7 checks passed
@TT-billteng TT-billteng deleted the yan-zaretskiy/remove-fmt-runtime branch September 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants