#12520: Adding noc_async_writes_flushed between mcast writes and mcast semaphore sets for BH #12627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhullar-tt
requested review from
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-aho
approved these changes
Sep 13, 2024
Yes I will ifdef it, just put this pr up to bombard the BH post commit workflow |
abhullar-tt
force-pushed
the
abhullar/nd-mismatch
branch
from
a285477
to
7308e2a
Compare
abhullar-tt
requested review from
mywoodstock,
shwetankTT,
sankarmanoj-tt,
pavlejosipovic and
bbradelTT
as code owners
…itigate ND mismatches
abhullar-tt
force-pushed
the
abhullar/nd-mismatch
branch
from
7308e2a
to
7380bb1
Compare
abhullar-tt
changed the title
mywoodstock
approved these changes
Sep 14, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12520
Problem description
After enabling cmd buffer FIFOs (needed to stop ND hangs with this test), this test starting having ND mismatches
What's changed
Added some
noc_async_writes_flushedbetween mcast writes and mcast semaphore sets. These use different cmd buffers but it seems like order is preserved on GS/WH but not on BH.Needs further investigation about why this is needed. #12678
When mcast write and mcast sem set use the same cmd buffer then we don't have this issue (https://github.com/tenstorrent/tt-metal/tree/abhullar/nd-mismatch-2)
FYI @davorchap
Checklist