-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed Sharded Layernorm/RMSNorm #12635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpaigwar
requested review from
eyonland,
patrickroberts,
yan-zaretskiy,
cfjchu,
xanderchin,
TT-BrianLiu,
ayerofieiev-tt,
dmakoviichuk-tt,
razorback3,
dongjin-na,
yugaoTT and
tt-aho
as code owners
September 16, 2024 14:03
kpaigwar
force-pushed
the
kpaigwar/distrbuted_sharded_LN
branch
from
September 16, 2024 14:59
c58601e
to
943bb69
Compare
kpaigwar
force-pushed
the
kpaigwar/distrbuted_sharded_LN
branch
from
September 20, 2024 12:04
092c7d2
to
10df9ee
Compare
TT-BrianLiu
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change copyright to 2024 for all new files.
kpaigwar
force-pushed
the
kpaigwar/distrbuted_sharded_LN
branch
from
September 20, 2024 17:58
f646f4e
to
4a8172f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces sharded distributed LayerNorm for pre/post-all-gather stages, leveraging existing single device sharded LayerNorm host code. The implementation includes new kernels and comprehensive test coverage.
Key Changes
Implemented sharded distributed LayerNorm for pre/post-all-gather stages
Performance and Accuracy
New Kernel Development
Test Coverage
Performance Benchmarks
Future Steps
batch_size
> 32Checklist